From 464fe71202e75de863f796940ed9be7fb4b82023 Mon Sep 17 00:00:00 2001 From: Daniel <71837281+darmiel@users.noreply.github.com> Date: Sun, 18 Dec 2022 04:14:05 +0100 Subject: [PATCH 1/6] ci: added pr linter workflow (#363) --- .github/workflows/pr_lint_review.yaml | 62 +++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 .github/workflows/pr_lint_review.yaml diff --git a/.github/workflows/pr_lint_review.yaml b/.github/workflows/pr_lint_review.yaml new file mode 100644 index 00000000..2d4546c7 --- /dev/null +++ b/.github/workflows/pr_lint_review.yaml @@ -0,0 +1,62 @@ +name: "🧐 [Lint] Checking IR files" + +on: + pull_request: + paths: '**.ir' + +jobs: + lint: + name: "🐛 Looking for issues" + runs-on: ubuntu-latest + steps: + # checkout IRDB + - uses: actions/checkout@v3 + with: + fetch-depth: 0 + + # checkout Linter + - uses: actions/checkout@v3 + with: + repository: 'darmiel/fff-ir-lint' + path: fff-ir-lint + + # only check files changed in the PR + - name: Get Changed Files + id: changed-files + uses: tj-actions/changed-files@v29.0.7 + with: + files: "**/*.ir" + + - uses: actions/setup-python@v4 + with: + python-version: '3.10' + + - name: Run Linter if at least 1 IR File Changed + uses: mathiasvr/command-output@v1.1.0 + id: run + continue-on-error: true + with: + run: python fff-ir-lint/main.py github2 ${{ steps.changed-files.outputs.all_changed_files }} + + - uses: ntsd/auto-request-changes-action@v2 + name: "❌ Request Changes" + if: ${{ steps.run.outputs.stderr }} + with: + github-token: "${{ secrets.GITHUB_TOKEN }}" + comment-body: | + ${{ steps.run.outputs.stdout }} + + # optional: auto approve PRs with valid .ir files + - uses: hmarr/auto-approve-action@v2 + name: "✅ Approve Changes" + if: ${{ ! steps.run.outputs.stderr }} + with: + github-token: "${{ secrets.GITHUB_TOKEN }}" + review-message: | + > **Note**: This approval was *auto-generated* + + LGTM! 😊 + + - name: Fail Pipeline + if: ${{ steps.run.outputs.stderr }} + run: exit 1 \ No newline at end of file From 72ec9b264a6c2c3479f5900c91e53bc819e5e036 Mon Sep 17 00:00:00 2001 From: niko <95256956+T0astLover@users.noreply.github.com> Date: Sun, 18 Dec 2022 12:07:37 +0100 Subject: [PATCH 2/6] Northerns Light Chain :D --- .../Northerns Light Chain.ir | 62 +++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 LED_Lighting/Northerns Light Cain/Northerns Light Chain.ir diff --git a/LED_Lighting/Northerns Light Cain/Northerns Light Chain.ir b/LED_Lighting/Northerns Light Cain/Northerns Light Chain.ir new file mode 100644 index 00000000..35e41a37 --- /dev/null +++ b/LED_Lighting/Northerns Light Cain/Northerns Light Chain.ir @@ -0,0 +1,62 @@ +Filetype: IR signals file +Version: 1 +# +name: Led +type: parsed +protocol: NECext +address: 00 EF 00 00 +command: 1C E3 00 00 +# +name: Off +type: parsed +protocol: NECext +address: 00 EF 00 00 +command: 1D E2 00 00 +# +name: Auto +type: parsed +protocol: NECext +address: 00 EF 00 00 +command: 1E E1 00 00 +# +name: Speed +type: parsed +protocol: NECext +address: 00 EF 00 00 +command: 1F E0 00 00 +# +name: Fade +type: parsed +protocol: NECext +address: 00 EF 00 00 +command: 0B F4 00 00 +# +name: Jump +type: parsed +protocol: NECext +address: 00 EF 00 00 +command: 0F F0 00 00 +# +name: Asyn_fade +type: parsed +protocol: NECext +address: 00 EF 00 00 +command: 13 EC 00 00 +# +name: Red +type: parsed +protocol: NECext +address: 00 EF 00 00 +command: 00 FF 00 00 +# +name: Grenn +type: parsed +protocol: NECext +address: 00 EF 00 00 +command: 01 FE 00 00 +# +name: Blue +type: parsed +protocol: NECext +address: 00 EF 00 00 +command: 02 FD 00 00 From 6f62cfad237527aa31dcf80b09aeee4472483929 Mon Sep 17 00:00:00 2001 From: niko <95256956+T0astLover@users.noreply.github.com> Date: Sun, 18 Dec 2022 12:18:23 +0100 Subject: [PATCH 3/6] (Rusta) christmas tree candle lights --- .../(Rusta) christmas tree candle lights.ir | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 LED_Lighting/Christmas tree candle lights/(Rusta) christmas tree candle lights.ir diff --git a/LED_Lighting/Christmas tree candle lights/(Rusta) christmas tree candle lights.ir b/LED_Lighting/Christmas tree candle lights/(Rusta) christmas tree candle lights.ir new file mode 100644 index 00000000..bac4cb92 --- /dev/null +++ b/LED_Lighting/Christmas tree candle lights/(Rusta) christmas tree candle lights.ir @@ -0,0 +1,38 @@ +Filetype: IR signals file +Version: 1 +# +name: On +type: raw +frequency: 38000 +duty_cycle: 0.330000 +data: 9174 4018 678 433 557 521 560 519 617 435 642 437 584 495 1071 1116 1069 1119 550 +# +name: Off +type: raw +frequency: 38000 +duty_cycle: 0.330000 +data: 9212 4018 643 436 558 519 536 542 594 459 1131 1079 1106 1079 591 461 587 493 557 +# +name: Plus +type: raw +frequency: 38000 +duty_cycle: 0.330000 +data: 9207 4021 561 518 557 520 535 543 593 460 1104 1107 536 544 1076 1110 559 521 505 +# +name: _ +type: raw +frequency: 38000 +duty_cycle: 0.330000 +data: 9163 4066 566 512 563 514 540 538 568 483 1109 1102 568 511 1081 1106 1050 1136 509 +# +name: Flickering +type: raw +frequency: 38000 +duty_cycle: 0.330000 +data: 9190 4034 599 512 539 539 540 538 569 482 1109 1101 1083 1103 1080 1083 559 544 510 +# +name: Timer +type: raw +frequency: 38000 +duty_cycle: 0.330000 +data: 9186 4070 565 514 561 516 539 539 540 511 1109 1102 1082 1103 567 486 590 516 533 From f8ab9de19c9f31e9204bfc6195d5a729d18f9448 Mon Sep 17 00:00:00 2001 From: UberGuidoZ <57457139+UberGuidoZ@users.noreply.github.com> Date: Mon, 19 Dec 2022 16:39:12 -0800 Subject: [PATCH 4/6] Not needed for this commit --- .github/workflows/pr_lint_review.yaml | 62 --------------------------- 1 file changed, 62 deletions(-) delete mode 100644 .github/workflows/pr_lint_review.yaml diff --git a/.github/workflows/pr_lint_review.yaml b/.github/workflows/pr_lint_review.yaml deleted file mode 100644 index 2d4546c7..00000000 --- a/.github/workflows/pr_lint_review.yaml +++ /dev/null @@ -1,62 +0,0 @@ -name: "🧐 [Lint] Checking IR files" - -on: - pull_request: - paths: '**.ir' - -jobs: - lint: - name: "🐛 Looking for issues" - runs-on: ubuntu-latest - steps: - # checkout IRDB - - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - # checkout Linter - - uses: actions/checkout@v3 - with: - repository: 'darmiel/fff-ir-lint' - path: fff-ir-lint - - # only check files changed in the PR - - name: Get Changed Files - id: changed-files - uses: tj-actions/changed-files@v29.0.7 - with: - files: "**/*.ir" - - - uses: actions/setup-python@v4 - with: - python-version: '3.10' - - - name: Run Linter if at least 1 IR File Changed - uses: mathiasvr/command-output@v1.1.0 - id: run - continue-on-error: true - with: - run: python fff-ir-lint/main.py github2 ${{ steps.changed-files.outputs.all_changed_files }} - - - uses: ntsd/auto-request-changes-action@v2 - name: "❌ Request Changes" - if: ${{ steps.run.outputs.stderr }} - with: - github-token: "${{ secrets.GITHUB_TOKEN }}" - comment-body: | - ${{ steps.run.outputs.stdout }} - - # optional: auto approve PRs with valid .ir files - - uses: hmarr/auto-approve-action@v2 - name: "✅ Approve Changes" - if: ${{ ! steps.run.outputs.stderr }} - with: - github-token: "${{ secrets.GITHUB_TOKEN }}" - review-message: | - > **Note**: This approval was *auto-generated* - - LGTM! 😊 - - - name: Fail Pipeline - if: ${{ steps.run.outputs.stderr }} - run: exit 1 \ No newline at end of file From 65187888b5ecdc0c4792b9b6979a6332dc883908 Mon Sep 17 00:00:00 2001 From: UberGuidoZ <57457139+UberGuidoZ@users.noreply.github.com> Date: Mon, 19 Dec 2022 16:41:24 -0800 Subject: [PATCH 5/6] Renamed and added description to comment --- .../Rusta_Xmas_Candle.ir} | 2 ++ 1 file changed, 2 insertions(+) rename LED_Lighting/{Christmas tree candle lights/(Rusta) christmas tree candle lights.ir => Rusta_Christmas_Tree_Candle/Rusta_Xmas_Candle.ir} (96%) diff --git a/LED_Lighting/Christmas tree candle lights/(Rusta) christmas tree candle lights.ir b/LED_Lighting/Rusta_Christmas_Tree_Candle/Rusta_Xmas_Candle.ir similarity index 96% rename from LED_Lighting/Christmas tree candle lights/(Rusta) christmas tree candle lights.ir rename to LED_Lighting/Rusta_Christmas_Tree_Candle/Rusta_Xmas_Candle.ir index bac4cb92..f5b50bb1 100644 --- a/LED_Lighting/Christmas tree candle lights/(Rusta) christmas tree candle lights.ir +++ b/LED_Lighting/Rusta_Christmas_Tree_Candle/Rusta_Xmas_Candle.ir @@ -1,6 +1,8 @@ Filetype: IR signals file Version: 1 # +# Rusta Christmas Tree Candle LED +# name: On type: raw frequency: 38000 From 1c3925b465177718e328b96758c0105047c01a45 Mon Sep 17 00:00:00 2001 From: UberGuidoZ <57457139+UberGuidoZ@users.noreply.github.com> Date: Mon, 19 Dec 2022 16:42:30 -0800 Subject: [PATCH 6/6] Renamed and added description to comment --- .../Northerns_Light_Chain.ir} | 2 ++ 1 file changed, 2 insertions(+) rename LED_Lighting/{Northerns Light Cain/Northerns Light Chain.ir => Northerns_Light/Northerns_Light_Chain.ir} (96%) diff --git a/LED_Lighting/Northerns Light Cain/Northerns Light Chain.ir b/LED_Lighting/Northerns_Light/Northerns_Light_Chain.ir similarity index 96% rename from LED_Lighting/Northerns Light Cain/Northerns Light Chain.ir rename to LED_Lighting/Northerns_Light/Northerns_Light_Chain.ir index 35e41a37..6e29af5f 100644 --- a/LED_Lighting/Northerns Light Cain/Northerns Light Chain.ir +++ b/LED_Lighting/Northerns_Light/Northerns_Light_Chain.ir @@ -1,6 +1,8 @@ Filetype: IR signals file Version: 1 # +# Northerns Light Chain LED +# name: Led type: parsed protocol: NECext